Skip to content

pyo3 downcasts changed to casts #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 28, 2025
Merged

pyo3 downcasts changed to casts #65

merged 2 commits into from
Sep 28, 2025

Conversation

jessekrubin
Copy link
Contributor

@jessekrubin jessekrubin commented Sep 27, 2025 •
edited
Loading

  • Ran: rg downcast -l | xargs -n1 -t sed -i 's/downcast/cast/g'
  • Bopped around and accepted/staged changes that were pyo3 related (downcast_ref and non pyo3 changes were not staged)
  • Also ran cargo fmt and lint checks
  • updated das changelog

davidhewitt
davidhewitt approved these changes Sep 27, 2025
View reviewed changes
Copy link
Member

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@davidhewitt davidhewitt merged commit 0837d91 into PyO3:main Sep 28, 2025
34 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davidhewitt davidhewitt davidhewitt approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jessekrubin @davidhewitt